Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to resolve issues with the new injection system.
Injections are now dynamically checked as part of the main interval.
We check for injections by query selecting the injected elements and checking if they are marked as being injected (via an attribute).
This way, if old shorts are loaded and the injected elements are removed, we can react to that and inject them again.
This unfortunately removes the error messaging, but Im not sure if that was particularly useful anyway
When adding new injected elements, you now should:
InjectionItemsEnum
(unless its a child of one thats already there)<your element>.setAttribute(INJECTION_MARKER, "");
to your method that inserts the new elementinjectIfNotPresent()
- you can just copypaste one thats there (note the getter should be for the element that has the marker)