-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove length 3 repr_simd vectors #66
Comments
Hi, thanks for letting me know! Fortunately this will be easy to fix on my side, I'll just make the non-power-of-two vectors in my That said, I liked the fact that it "worked" and that the compiler would silently round up the length to the next power of two. Very often I like to use a
I wish it could keep "working" as it did, but I understand that this regression may make life significantly easier for the backend, so let's roll with it! |
I agree with all of your reasoning and I'll open an issue with |
See yoanlcq/vek#66 This ends up a bit slower than the previous baseline, but remains way faster than falling back to the C representation. Bench for the C repr: AMD Ryzen 9 3900X 12-Core Processor (AMD64 Family 23 Model 113 Stepping 0) $ cargo bench --bench benchmark -- --baseline master tracescene/10x10x4 time: [525.46 us 527.30 us 529.31 us] change: [+74.250% +75.107% +75.981%] (p = 0.00 < 0.05) Performance has regressed.
In rust-lang/rust#80652 we are removing support for non-power-of-two vector lengths with
#[repr(simd)]
from nightly Rust, andvek
is one of the crates that will be effected. Just wanted to give a heads up before we make the change. If you have any questions feel free to ask!The text was updated successfully, but these errors were encountered: