Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Support for no_std #41

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Implement Support for no_std #41

merged 1 commit into from
Mar 29, 2020

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Nov 28, 2019

num-traits just added support for no_std, so vek can now support no_std as well.

Resolves #20

num-traits just added support for no_std, so vek can now support no_std
as well.
@yoanlcq
Copy link
Owner

yoanlcq commented Nov 28, 2019

Looks great! I think it's a good opportunity to add a no_std CI target, as suggested by @cbiffle in #20 ; quoting :

Also, consider adding a no-std target to your continuous build to catch regressions here. thumbv7em-none-eabihf is a supported target on stable and nightly and would be a reasonable choice, but in general, any target with -none- in the triple instead of e.g. -linux- should do.

There are a lot of commented targets in the current .travis.yml; it should be enough to enable at least one of these that's no_std, whichever is most convenient/common I guess :)

Thanks a lot for this work.

@yoanlcq
Copy link
Owner

yoanlcq commented Mar 29, 2020

Sorry for the delay, I kind of waited for changes in .travis.yml as part of the PR, but then time passed and I just forgot about it.
So at long last, let's merge, and I guess I'll add a no_std CI target myself! Thanks again.

@yoanlcq yoanlcq merged commit 4d6c3ea into yoanlcq:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate is not actually no_std
2 participants