-
Notifications
You must be signed in to change notification settings - Fork 0
[BC] Add sf 7.0 and drop 4.4 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
composer.json
Outdated
"yoanm/jsonrpc-http-server-swagger-doc-sdk": "^v1.0", | ||
"yoanm/jsonrpc-server-doc-sdk": "^v1.0", | ||
"yoanm/symfony-jsonrpc-http-server-doc": "^1.1" | ||
"yoanm/symfony-jsonrpc-http-server-doc": "^1.1 || dev-feature/increase-supported-versions-sf7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
517acc6
to
cd3efb3
Compare
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317) | ||
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' | ||
- job-name: Up to date versions - Sf 5.4 case | ||
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 ! | ||
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }} | ||
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}' | ||
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-max }} | ||
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317) | ||
pkg-extra-constraints: behat/gherkin:~4.12.0 | ||
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 36 36
=========================================
Hits 36 36
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd3efb3
to
978bf13
Compare
978bf13
to
c9ba5c3
Compare
No description provided.