Skip to content

Fix behat coverage not generated #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2025
Merged

Fix behat coverage not generated #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb07e7
Fix behat coverage not generated
yoanm Aug 30, 2025
8ca45b0
Fix behat unstable version
yoanm Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/reusable-CI-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,15 @@ jobs:
static-checks:
name: Static analysis
runs-on: ubuntu-latest
env:
SC_PHP_VERSION: 8.2 # Latest supported
steps:
- uses: actions/checkout@v4

- name: Setup PHP 8.2
- name: Setup PHP ${{ env.SC_PHP_VERSION }}
uses: shivammathur/setup-php@v2
with:
php-version: 8.2 # Latest supported
php-version: ${{ env.SC_PHP_VERSION }}
tools: composer
coverage: none
env:
Expand All @@ -148,7 +150,7 @@ jobs:
path: |
~/.composer
# Clear the cache if composer json (as composer.lock is in the repo) has been updated
key: tests-${{ env.PHP_VERSION }}-${{ hashFiles('composer.json') }}
key: tests-${{ env.SC_PHP_VERSION }}-${{ hashFiles('composer.json') }}

- name: Build
run: make build
Expand All @@ -164,7 +166,7 @@ jobs:
name: Nightly - PHP ${{ matrix.php-version }} & Symfony ${{ matrix.symfony-version }}
runs-on: ubuntu-latest
env:
COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+'
COMPOSER_OPTIONS: '--optimize-autoloader --prefer-dist --ignore-platform-req=php+'
continue-on-error: true
needs: [ static-checks, tests ]
strategy:
Expand All @@ -180,6 +182,9 @@ jobs:
include:
- symfony-version: '6.3' # Next symfony minor version to manage with latest supported PHP version
php-version: '8.2'
- symfony-version: '4.4' # Fix to avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
php-version: '8.3'
pkg-extra-constraints: 'behat/gherkin:~4.12.0'

steps:
- name: Check out code
Expand Down Expand Up @@ -208,14 +213,15 @@ jobs:
- name: Build
run: |
composer config minimum-stability dev \
&& composer require -W ${{ env.COMPOSER_OPTIONS }} \
&& composer require -W ${{ env.COMPOSER_OPTIONS }} --prefer-stable \
symfony/http-foundation:^${{ matrix.symfony-version }} \
symfony/http-kernel:^${{ matrix.symfony-version }} \
symfony/config:^${{ matrix.symfony-version }} \
symfony/dependency-injection:^${{ matrix.symfony-version }} \
symfony/event-dispatcher:^${{ matrix.symfony-version }} \
symfony/routing:^${{ matrix.symfony-version }} \
&& composer update ${{ env.COMPOSER_OPTIONS }} \
${{ matrix.pkg-extra-constraints }} \
&& composer update ${{ env.COMPOSER_OPTIONS }} --prefer-stable \
&& make build

- name: Test
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"yoanm/jsonrpc-server-sdk": "^3.3"
},
"require-dev": {
"behat/behat": "^3.9.0",
"behat/behat": "^3.9.0,<=3.16.1",
"dvdoug/behat-code-coverage": "^5.0",
"matthiasnoback/symfony-config-test": "^4.0",
"matthiasnoback/symfony-dependency-injection-test": "^4.0",
Expand Down