Skip to content

Upgrade max versions #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2025
Merged

Upgrade max versions #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e840cfb
Upgrade max php version
yoanm Aug 30, 2025
3c16e49
Upgrade max symfony version
yoanm Aug 30, 2025
0c718c6
Fix version conflicts
yoanm Aug 30, 2025
1d15d8b
Fix symfony requirements
yoanm Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions .github/workflows/reusable-CI-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ on:
required: false
type: string
php-max-version:
default: '8.2'
default: '8.4'
description: Highest PHP version to assess (e.g Highest supported version)
required: false
type: string
php-next-version:
default: '8.3'
default: '8.5'
description: Next (currently not supported) PHP version to assess (e.g Current dev version)
required: false
type: string
Expand All @@ -27,12 +27,12 @@ on:
required: false
type: string
symfony-max-version:
default: '6.0'
default: '6.4'
description: Highest Symfony version to assess (e.g Highest supported version)
required: false
type: string
symfony-next-version:
default: '6.3'
default: '7.0'
description: Next (currently not supported) Symfony version to assess (e.g Current dev version)
required: false
type: string
Expand Down Expand Up @@ -62,15 +62,16 @@ jobs:
php-version: '${{ inputs.php-max-version }}'
symfony-version: '5.4'
## Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: behat/gherkin:~4.12.0
# Fix - symfony/yaml - Avoid issue with Sf YAML 6.4+ and Framework bundle
pkg-extra-constraints: behat/gherkin:~4.12.0 symfony/yaml:~6.4.0
- job-name: Bare minimum # => Lowest versions allowed by composer config
php-version: '${{ inputs.php-min-version }}'
symfony-version: '${{ inputs.symfony-min-version }}'
- job-name: Bare minimum - Special case - Symfony 5.4
php-version: '${{ inputs.php-min-version }}'
symfony-version: '5.4'
- job-name: Late migration - PHP # => Highest symfony version with lowest php version allowed by composer config
php-version: '${{ inputs.php-min-version }}'
php-version: ${{ ( inputs.symfony-max-version == '6.4' && inputs.php-min-version == '8.0' ) && '8.1' || inputs.php-min-version }} # Fix - Sf 6.4 require php 8.1 minimum !
symfony-version: '${{ inputs.symfony-max-version }}'
- job-name: Late migration - Symfony # => Lowest symfony version with highest php version allowed by composer config
php-version: '${{ inputs.php-max-version }}'
Expand Down Expand Up @@ -115,12 +116,11 @@ jobs:
run: |
SF_CONSTRAINT="~${{ matrix.symfony-version }}.0"
composer require -W \
symfony/http-foundation:${SF_CONSTRAINT} \
symfony/http-kernel:${SF_CONSTRAINT} \
symfony/config:${SF_CONSTRAINT} \
symfony/dependency-injection:${SF_CONSTRAINT} \
symfony/event-dispatcher:${SF_CONSTRAINT} \
symfony/routing:${SF_CONSTRAINT} \
symfony/http-foundation:${SF_CONSTRAINT} \
symfony/http-kernel:${SF_CONSTRAINT} \
${{ matrix.pkg-extra-constraints }} \
&& make build

Expand Down Expand Up @@ -199,12 +199,11 @@ jobs:
run: |
SF_CONSTRAINT="~${{ env.SYMFONY_VERSION }}.0"
composer require -W \
symfony/http-foundation:${SF_CONSTRAINT} \
symfony/http-kernel:${SF_CONSTRAINT} \
symfony/config:${SF_CONSTRAINT} \
symfony/dependency-injection:${SF_CONSTRAINT} \
symfony/event-dispatcher:${SF_CONSTRAINT} \
symfony/routing:${SF_CONSTRAINT} \
symfony/http-foundation:${SF_CONSTRAINT} \
symfony/http-kernel:${SF_CONSTRAINT} \
&& make build

- name: ComposerRequireChecker
Expand Down Expand Up @@ -239,12 +238,15 @@ jobs:
php-version: ${{ inputs.php-max-version }}
symfony-version: ${{ inputs.symfony-next-version }}
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: behat/gherkin:~4.12.0
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( inputs.symfony-next-version == '7.0' && inputs.php-max-version == '8.4' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
- job-name: Symfony - With lowest supported PHP version
php-version: ${{ inputs.php-min-version > 8.1 && inputs.php-min-version || '8.1' }} # Fix - Sf 6.3 (current next) require php 8.1 minimum !
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
php-version: ${{ ( inputs.symfony-next-version == '7.0' && inputs.php-min-version == '8.0' ) && '8.2' || inputs.php-min-version }}
symfony-version: ${{ inputs.symfony-next-version }}
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: behat/gherkin:~4.12.0
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( inputs.symfony-next-version == '7.0' && inputs.php-min-version == '8.0' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}

steps:
- name: Check out code
Expand Down Expand Up @@ -278,12 +280,11 @@ jobs:
SF_CONSTRAINT="~${{ matrix.symfony-version }}.0@dev"
composer config minimum-stability dev \
&& composer require -W \
symfony/http-foundation:${SF_CONSTRAINT} \
symfony/http-kernel:${SF_CONSTRAINT} \
symfony/config:${SF_CONSTRAINT} \
symfony/dependency-injection:${SF_CONSTRAINT} \
symfony/event-dispatcher:${SF_CONSTRAINT} \
symfony/routing:${SF_CONSTRAINT} \
symfony/http-foundation:${SF_CONSTRAINT} \
symfony/http-kernel:${SF_CONSTRAINT} \
${{ matrix.pkg-extra-constraints }} \
&& make build

Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"require-dev": {
"behat/behat": "^3.9.0,<=3.16.1",
"dvdoug/behat-code-coverage": "^5.0",
"matthiasnoback/symfony-config-test": "^4.0",
"matthiasnoback/symfony-dependency-injection-test": "^4.0",
"matthiasnoback/symfony-config-test": "^4.0 || ^5.0",
"matthiasnoback/symfony-dependency-injection-test": "^4.0 || ^5.0",
"phpspec/prophecy": "^1.15",
"phpspec/prophecy-phpunit": "^2.0",
"phpunit/php-code-coverage": "^9.2.4",
Expand Down
Loading