Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show in recipes explorer skipped recipes #317

Closed
Paullgk opened this issue Sep 3, 2024 · 2 comments · Fixed by #322
Closed

Show in recipes explorer skipped recipes #317

Paullgk opened this issue Sep 3, 2024 · 2 comments · Fixed by #322
Assignees
Labels
enhancement New feature or request

Comments

@Paullgk
Copy link

Paullgk commented Sep 3, 2024

Currently, when scanning the project the extension prevents to add in recipes explorer the recipe that have been skipped by Bitbake.
As an example, if I want to add the the package virt-manager from meta-virtualization (https://git.yoctoproject.org/meta-virtualization/tree/recipes-extended/virt-manager/virt-manager_4.1.0.bb?h=master); it requires by default wayland or x11 distro features, and so will be skipped if the latter are not in the image being built:

pleguendekerneizon@ffde7735d379:~/PROJECTS/SEAPATH/seapath_yocto/build$ bitbake-layers show-recipes | grep virt-mana -C 5
  meta                 9.1.0114
vim-tiny:
  meta                 9.1.0114
virglrenderer:
  meta                 1.0.1 (skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES))
virt-manager:
  meta-virtualization  4.1.0 (skipped: one of 'x11 wayland' needs to be in DISTRO_FEATURES)
virt-viewer:
  meta-virtualization  11.0 (skipped: one of 'wayland x11' needs to be in DISTRO_FEATURES)
virt-what:
  meta-virtualization  1.21

The behavior of the extension is to not show at all the skipped recipe:
image

A nice feature would be to show the skipped recipe and display them maybe with a warning. The fact that recipe is not showing at all may lead to think a bug although this is an expected behavior.

@deribaucourt deribaucourt added the enhancement New feature or request label Sep 3, 2024
@deribaucourt deribaucourt self-assigned this Sep 3, 2024
@deribaucourt
Copy link
Member

Currently, we discard them from the recipe view. This would indeed allow users to keep browsing their files and determine why it was skipped. The implementation should be simple enough:

  • Add a "skipped" attribute in our recipe scan data structure
  • No longer discard skipped recipes, add the skipped attribute
  • Show the skipped attribute in the recipes view

@deribaucourt
Copy link
Member

Here's a preview that's going to be part of the next release
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants