View skipped recipes #322
Merged
View skipped recipes #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to track which recipes were marked as skipped by bitbake. Skipped recipes are recipes that are not buildable in the current configuration, but available in the workspace.
We use this variable to determine if the scan result data saved in the workspace state is up to date. Since this should be modified whenever the structure of the scan data changes, it makes sense to keep it in the same file as the scan data structure. Also added a reminder comment to increment the version number when the structure changes.
We are going to display these recipes with a description in the BitbakeRecipesView. It will allow users to see skipped recipes they would be interested in, and understand why they are skipped.
Now that we keep and track skipped recipe items, we want to know their source. Adapt the regex to capture the filename and truncate the skipped reason. It is already captured in the ElementInfo.skipped from the recipe scan.
This will allow users to know why recipes are not buildable when they were skipped. A warning icon and description will clearly present this. Not much performance impact for recipes array traversal since this is only done on the hand-selected active recipes.
|
|
Even though their shouldn't be many active recipes, we want to avoid looping multiple times through the list of recipes.
The SCAN_COMPLETE event needed to be reordered so that the data is passed before computing the view.
deribaucourt
force-pushed
the
view-skipped-recipes
branch
from
9cd9cb7 to
a64b54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317