Terminal colors #119
Merged
Terminal colors #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
node-pty will be used to provider a better interactive terminal. However, VSCode uses electron which has it's own npm There are discussions which failed to provide other workarounds
The format of the files and package-lock.json where updated by npm |
deribaucourt
force-pushed
the
terminal-colors
branch
from
52fe519 to
bcb79e6
Compare
|
|
WilsonZiweiWang
previously approved these changes
Feb 20, 2024
node-pty will be used to provider a better interactive terminal. It's required to have colors and progress bars from bitbake. Explanation: microsoft/vscode#155444 (comment) However, VSCode uses electron which has it's own npm NODE_MODULE_VERSION. I had to use `@electron/rebuild` to match the version. I wonder if it would break when VSCode updates electron. There are discussions which failed to provide other workarounds (we don't use webpack yet): - microsoft/node-pty#582 - microsoft/vscode#658 The format of the files and package-lock.json where updated by npm install.
Following the representation from microsoft/vscode#155444 (comment) This allows colors and progress bars to render from bitbake.
Compared to child_process.spawn, the stdout data buffer from node-pty ends lines with \n instead of \r\n. We must update all our regexes and splits. The regex make \r so that we avoid potential compatibility issues.
We'll be using dynamic imports instead to comply with both the vscode and native jest environments.
VSCode and the Jest native environment use conflicting NODE_MODULE_VERSION. We have to use node-pty from VSCode when running in the VSCode environment and the regular node-pty when running in Jest. Following the idea presented in: microsoft/vscode#658 (comment) We use dynamic imports to load the correct node-pty. The types must still be imported normally at compile time.
- Update import paths for ProcessUtils - Update newline from \n to \r\n - Update function names for onData and onExit
node-pty was truncating the output of the `ps` command, which was causing the `ps` command to not return the expected output. In turn, bitbake processes were not being detected and stopped on terminal close.
deribaucourt
force-pushed
the
terminal-colors
branch
from
5193593 to
2d0e017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.