Use synchronize option to sync settings #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonZiweiWang
force-pushed
the
Sync-settings
branch
from
7376536 to
ad7a3f5
Compare
WilsonZiweiWang
changed the title
WilsonZiweiWang
force-pushed
the
Sync-settings
branch
2 times, most recently
from
cfe3e1a to
3f0c5fc
Compare
Though this option is marked as deprecated, we can't fully embrach the recommended pull-model for syncing configuration as the logger's logging level can't be synced in the same way like others. It needs to be updated immediately instead of being fetched from the client when needed. More info: https://code.visualstudio.com/api/language-extensions/language-server-extension-guide#explaining-the-language-server
WilsonZiweiWang
force-pushed
the
Sync-settings
branch
from
3f0c5fc to
67c9282
Compare
deribaucourt
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The synchronize option is marked as deprecated but what we did to sync the settings was not a good practice either. The recommended pull-model for configurations is demonstrated here. However, this model doesn't really fit our case as the logging level needs an immediate update but others can be fetched when needed.
One of the advantages of using the pull-model is it can specify the scope (user/workspace/workspaceFolder) of the configurations before fetching.