Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add rename to local python and shell symbols #225

Conversation

idillon-sfl
Copy link
Member

@idillon-sfl idillon-sfl commented May 28, 2024

This adds rename on Python and Shell local symbols.

Example:

foo_global='foo'

python() {
    foo_local_python='foo'
    print(foo_local_python)
    d.getVar('foo_global')
}

do_stuff() {
    echo "${foo_global}"
    local foo='foo_local_shell'
    echo "$foo_local_shell"
}

Here it adds rename to foo_local_python and foo_local_shell. foo_global is already handled, and #215 fixes a couple of things on it.

@idillon-sfl idillon-sfl force-pushed the Task-14846-add-rename-to-python-and-bash branch 3 times, most recently from 2f6f9d2 to dd7aa73 Compare May 28, 2024 02:45
@idillon-sfl idillon-sfl marked this pull request as draft May 28, 2024 05:07
@idillon-sfl idillon-sfl force-pushed the Task-14846-add-rename-to-python-and-bash branch from dd7aa73 to b3f5935 Compare May 28, 2024 15:51
@idillon-sfl idillon-sfl force-pushed the Task-14846-add-rename-to-python-and-bash branch from b3f5935 to 1ef429e Compare May 28, 2024 15:52
@idillon-sfl idillon-sfl changed the title Chore: Add rename to non-global python and shell symbols Chore: Add rename to local python and shell symbols May 28, 2024
@idillon-sfl idillon-sfl marked this pull request as ready for review May 28, 2024 16:06
Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Minor suggestions/questions.

@idillon-sfl idillon-sfl merged commit d3c5508 into yoctoproject:staging May 31, 2024
5 checks passed
@idillon-sfl idillon-sfl deleted the Task-14846-add-rename-to-python-and-bash branch May 31, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants