Feat: Import require/inherit in Bash and Python context #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idillon-sfl
force-pushed
the
Feature-14214-import-require-inherit-bash-and-python-context-2
branch
from
d7bca83 to
29e665e
Compare
|
sorry, should have checked the tests before calling everyone for review |
idillon-sfl
force-pushed
the
Feature-14214-import-require-inherit-bash-and-python-context-2
branch
from
cf08882 to
c9ee01f
Compare
deribaucourt
requested changes
Jun 13, 2024
idillon-sfl
commented
Jun 13, 2024
idillon-sfl
force-pushed
the
Feature-14214-import-require-inherit-bash-and-python-context-2
branch
from
c9ee01f to
be45ede
Compare
And rename related variables
…mbols in bash regions
…mbols in Python regions
…cument finished to generate
idillon-sfl
force-pushed
the
Feature-14214-import-require-inherit-bash-and-python-context-2
branch
from
54b272c to
ed463c6
Compare
deribaucourt
approved these changes
Jun 19, 2024
idillon-sfl
deleted the
Feature-14214-import-require-inherit-bash-and-python-context-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "definition" functionality to variables that are required, inherited or included into Bash or Python regions. It also filter out Pylance's
reportUndefinedVariablewhen the variable is actually defined. It even removes the requirement to make a new scan for filtering out shellchecksSC2154diagnostics when the variable actually exist.Lets take examples from the file
meta/recipes-core/busybox/busybox.incin Poky. After, a scan,find_cfgs(python region) won't appear anymore as undefined, and clicking on it will bring to its definition inmeta/classes-recipe/cml1.bbclass.cml1_do_configure(shell region) will also bring to its definition when clicked.