Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add SPDX licenses suggestions #266

Merged
merged 15 commits into from
Jul 12, 2024
Merged

Feat: Add SPDX licenses suggestions #266

merged 15 commits into from
Jul 12, 2024

Conversation

idillon-sfl
Copy link
Member

No description provided.

deribaucourt
deribaucourt requested changes Jun 26, 2024
View reviewed changes
server/src/completions/completion-item-data.d.ts Show resolved Hide resolved
server/src/completions/spdx-licenses.ts Show resolved Hide resolved
server/src/completions/spdx-licenses.ts Outdated Show resolved Hide resolved
server/src/completions/spdx-licenses.ts Outdated Show resolved Hide resolved
server/src/connectionHandlers/onCompletion.ts Outdated Show resolved Hide resolved
scripts/update-ref.sh Show resolved Hide resolved
server/src/__tests__/completions.test.ts Outdated Show resolved Hide resolved
server/src/__tests__/completions.test.ts Show resolved Hide resolved
server/src/__tests__/fixtures/completion.bb Outdated Show resolved Hide resolved
@deribaucourt
Copy link
Member

Very promising, a few implementation remarks. Keep it up!

@idillon-sfl idillon-sfl force-pushed the Feature-14949-SPDX-license-code-suggestions branch 4 times, most recently from 34bf08d to aa3def5 Compare July 5, 2024 14:23
deribaucourt
deribaucourt previously approved these changes Jul 12, 2024
View reviewed changes
idillon-sfl added 15 commits July 12, 2024 03:46
@idillon-sfl
Chore: Add script to fetch spdx licenses
83809bc
@idillon-sfl
Feat: Add SPDX licenses to completion items
24f313b
@idillon-sfl
Refactor: Move onCompletionResolve handler to onCompletion.ts
097d1bb
@idillon-sfl
Feat: Fetch SPDX license description on completion resolve
2bc14bb
@idillon-sfl
Chore: Improve accuracy of text to replace on completion for LICENSE
b0cd0f1
@idillon-sfl
Chore: Update github workflows to download spdx-licences
907bcbe
@idillon-sfl
Chore: Add script to update fetch-spdx-licenses.sh
c8a0c6c
@idillon-sfl
Chore: Add tests for SPDX licenses completion items
5842073
@idillon-sfl
Chore: Cache spdx license details
5e35e3e
@idillon-sfl
Fix: Completion on LICENSE variable with empty string
2e04e8a
@idillon-sfl
Chore: Shorten test for completion on LICENSE variable
b7b5d23
@idillon-sfl
Chore: Add lazy load to spdx-licenses.json
5728f05
@idillon-sfl
Chore: Get line the recommanded way.
95f243a 
According to the documentation for Position in the declaration file of vscode-languageserver-textdocument, using a character value 'greater than the line length' is 'implementation specific'. The comment for Range recommands to use the start of the next line instead.
@idillon-sfl
Refactor: Move getRangeOfTextToReplace to completions/util.ts
b71e0d9
@idillon-sfl
Chore: Add completion items LICENSE operators
588202e
@idillon-sfl idillon-sfl force-pushed the Feature-14949-SPDX-license-code-suggestions branch from 1a46534 to 588202e Compare July 12, 2024 07:47
@idillon-sfl
Copy link
Member Author

oh no, there was a conflict to solve. It needs to be approved again :/

@idillon-sfl idillon-sfl merged commit 9e97d82 into yoctoproject:staging Jul 12, 2024
5 checks passed
@idillon-sfl idillon-sfl deleted the Feature-14949-SPDX-license-code-suggestions branch July 12, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deribaucourt deribaucourt deribaucourt approved these changes

@WilsonZiweiWang WilsonZiweiWang Awaiting requested review from WilsonZiweiWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idillon-sfl @deribaucourt