Ssh agent forward shellenv #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kas will not forward the ssh-agent socket by default which means authentication to private git repositories will fail through our commands.
deribaucourt
force-pushed
the
ssh-agent-forward-shellenv
branch
from
2bd9143 to
0d55112
Compare
The previous code duplicated the logic to prepare the shell environment in temrinal profile and regular commands. Let's properly define the same one in both places.
deribaucourt
force-pushed
the
ssh-agent-forward-shellenv
branch
from
0d55112 to
7a19549
Compare
|
Closes #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve issues like #350