Added SAN extension to the generated certs #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While signing the certificate, a SAN extension for the CN is added using a temporary configuration file which in the end gets removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary, since modern browsers expect the domain name in the SAN extension. Due to the fact that HSTS is used, one cannot access the web ui even if the cert is added to the system's truststore.
While signing the certificate, a subjectAltName (SAN) extension for the CN is added using a temporary configuration file which in the end gets removed.
Tested in a Digital Ocean droplet. Before the change, I was not able to access the web ui using Chrome or Firefox on my Mac.