Fixes #1122 But in port service lookup that caused multiple entries of Port with same port number but different service name/description #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
yogeshojha
commented
Jul 20, 2024
yogeshojha
commented
- Port service lookup is by default using whatportis, but when it fails, python's built in socket library will be used to query service name (no plans to remove whatportis anytime soon)
- get_or_create was creating multiple entries of same port with different service name and description, in cases where whatportis fails. A new util function has been created to update the port info if it exists otherwise create it.
- A tiny UI bug where badges for ports cannot take the entire row length has also been fixed.
… and running service from whatportis or socket, added db function to update or create port based on service name or description
1 task
|
👋 Hi @yogeshojha, |
… and running service from whatportis or socket, added db function to update or create port based on service name or description
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.