Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error during tool update Fixes #1152 #1335

Merged

Conversation

yogeshojha
Copy link
Owner

This PR addresses an issue in the tool update process where the cd command failed to execute properly. The problem was resolved by enabling shell execution in the subprocess call.

This error occurred because cd is a shell built-in command, not an executable file. By setting shell=True, we allow the use of shell built-ins like cd.

  • Added shell=True parameter to the subprocess call in the run_command Celery task.

@yogeshojha yogeshojha self-assigned this Jul 29, 2024
@yogeshojha yogeshojha linked an issue Jul 29, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

👋 Hi @yogeshojha,
Thank you for sending this pull request.
Please make sure you have followed our contribution guidelines.
We will review this PR as soon as possible. Thank you for your patience.

web/api/views.py Dismissed Show dismissed Hide dismissed
@yogeshojha yogeshojha merged commit 9ca8d67 into master Jul 30, 2024
5 of 6 checks passed
@yogeshojha yogeshojha deleted the 1152-bug-updating-tools-hangs-and-results-500-error branch July 30, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Updating tools hangs and results 500 error
1 participant