Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-interactive installation parameter #973

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Add non-interactive installation parameter #973

merged 5 commits into from
Nov 21, 2023

Conversation

C0wnuts
Copy link
Contributor

@C0wnuts C0wnuts commented Oct 12, 2023

Add a non-interactive installation method via a new parameter to be passed to the install.sh script.
Essential for automated/industrialized systems (e.g. via Ansible or another automated environment creation system).

Modification of the comment for a better understanding
@AnonymousWP
Copy link
Contributor

Have you tested this thoroughly?

@C0wnuts
Copy link
Contributor Author

C0wnuts commented Oct 18, 2023

Hi, I tested on Debian 12, Ubuntu 22.04 and WSL 2 (Windows 10 with ubuntu distro). It worked fine.
I tested on existed install (with some dependencies already installed like Docker or Curl) and on fresh install without any dependencies, just run the install script in non-interractive mod : ./install.sh -n

For the super admin setup via Django, I followed the official documentation here: https://docs.djangoproject.com/en/4.2/ref/django-admin/#createsuperuser

@AnonymousWP
Copy link
Contributor

Awesome, can you add some documentation to the installation part of the README? After that I'll merge it into my fork.

@C0wnuts
Copy link
Contributor Author

C0wnuts commented Oct 18, 2023

I added some information inside the installation part. I hope that's enough, if not tell me what I need to add or change.

Copy link
Contributor

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just a few nitpicks, see comments.

Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AnonymousWP
Copy link
Contributor

We need to re-open this one for 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants