Added 5 new languages with a new dropdown menu, extracted hardcoded texts and added icons to sorting menu #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nish, French, Hindi, and Urdu - Created new strings.xml files for German (values-de), Spanish (values-es), French (values-fr), Hindi (values-hi), and Urdu (values-ur) with translations for all app strings. - Extracted the remaining hardcoded texts into Strings
|
I'll resolve the conflicts |
|
Done. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds multi-language support for 5 additional languages and improves the user interface with icon enhancements.
- Internationalized app with Hindi, Spanish, French, German, and Urdu translations
- Extracted hardcoded strings into proper string resources for localization
- Added intuitive icons to the sorting menu dropdown items for better UX
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Added 53 new string resources for internationalization |
| app/src/main/res/values-ur/strings.xml | Complete Urdu translation with 139 strings |
| app/src/main/res/values-hi/strings.xml | Complete Hindi translation with 138 strings |
| app/src/main/res/values-fr/strings.xml | Complete French translation with 140 strings |
| app/src/main/res/values-es/strings.xml | Complete Spanish translation with 140 strings |
| app/src/main/res/values-de/strings.xml | Complete German translation with 140 strings |
| LanguageUtil.kt | New utility for language management and locale updates |
| LanguageSelectionDialog.kt | New dialog component for language selection |
| MainActivity.kt | Language preference integration with context attachment |
| Settings.kt | Language selection UI and RTL support for back button |
| FilterMenu.kt | Added icons to sorting options and string resource extraction |
| Multiple UI components | Replaced hardcoded strings with localized string resources |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yogeshpaliyal
previously approved these changes
Sep 21, 2025
|
@anonfaded Please remove the background from language selection items |
…parent bg langauge items
…h, Hindi, and Urdu
|
@yogeshpaliyal Issues are resolved Screenshot
|
anonfaded
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
All issues resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 Multi-Language Support & UI Improvements
Screenshots