Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

リモートのPlayを遊べるようにする #447

Merged
merged 43 commits into from
Sep 21, 2024
Merged

リモートのPlayを遊べるようにする #447

merged 43 commits into from
Sep 21, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Sep 16, 2024 •
edited
Loading

close: #259

What

#259

Why

#259

Additional info (optional)

お気に入り登録したクリップが一つでも消えると何も取得できなくなる不具合の修正が入ってる

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 self-assigned this Sep 16, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Sep 16, 2024
@kozakura913
Copy link
Collaborator Author

close: #259

@kozakura913
Copy link
Collaborator Author

先に #448 をマージしたい

@kozakura913
Merge branch 'develop' into remote_flash
723a603 
# Conflicts:
#	packages/backend/migration/1726460877945-ClipFavoriteRemoteAuthor.js
@kozakura913
rm
f61584d
@kozakura913
MkRemoteCaution
52705ec
@kozakura913
import
289b089
@kozakura913
Copy link
Collaborator Author

先に #459 解決したい

@penginn-net
Copy link
Collaborator

なんでこれドライブのe2e落ちてるのかしら

@penginn-net
Copy link
Collaborator

もっかい回したら通った謎

@penginn-net
Copy link
Collaborator

チェンジログほしい

@kozakura913
Copy link
Collaborator Author

フロントにリモートから来たplayのURLをclipみたいに書き換える機能がほしい

@kozakura913
Copy link
Collaborator Author

#464 の問題起きてる

penginn-net
penginn-net requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@penginn-net penginn-net left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ユーザー画面Play一覧ではいいねしているのが表示されない
image

Playの画面でいいねできないMisskey仕様

packages/backend/src/server/api/endpoints/flash/show.ts Outdated Show resolved Hide resolved
@kozakura913
Copy link
Collaborator Author

ユーザーのplay一覧ではundefinedを返す仕様にした。全件DB叩くのは重そうだし
自身で作成したplayかisLikedがundefinedの時はボタンを表示しないようにした

@kozakura913 kozakura913 merged commit 67e077c into yojo-art:develop Sep 21, 2024
27 of 28 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penginn-net penginn-net penginn-net approved these changes

Assignees

@kozakura913 kozakura913

Labels
packages/backend packages/cherrypick-js packages/frontend
Projects
None yet
Milestone
yojo1.1.0
Development

Successfully merging this pull request may close these issues.

リモートのPlayで遊べるように
2 participants
@kozakura913 @penginn-net