Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リモートから添付されてきたクリップURLにホスト情報があると二重になる不具合を修正 #460

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Sep 18, 2024

What

リモートから添付されてきたクリップURLにホスト情報があればそれを優先する

Why

fix: #459

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 self-assigned this Sep 18, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.20%. Comparing base (de66bbf) to head (d7d0644).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #460       +/-   ##
============================================
- Coverage    38.69%   20.20%   -18.50%     
============================================
  Files         1662      787      -875     
  Lines       217452   117200   -100252     
  Branches      2849     1088     -1761     
============================================
- Hits         84148    23678    -60470     
+ Misses      132695    92934    -39761     
+ Partials       609      588       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 changed the title (フロント)リモートのリモートクリップURLを修正 リモートから添付されてきたクリップURLにホスト情報があると二重になる不具合を修正 Sep 18, 2024
@kozakura913 kozakura913 merged commit 455e6e7 into yojo-art:develop Sep 18, 2024
16 of 17 checks passed
@kozakura913 kozakura913 deleted the fix_459 branch September 18, 2024 04:11
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リモートクリップURLをリモートから見ると不正なURLが生成される
2 participants