Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: リアクション検索 #496

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Oct 15, 2024

What

ノートにつけられたリアクションを利用した検索ができるように

Why

Resolve #213
Close #214

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Oct 15, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -62728,6 +62728,26 @@
                     "type": "string",
                     "description": "指定した文字列を含むノートを返します"
                   },
+                  "reactions": {
+                    "type": "array",
+                    "description": "指定したリアクションがつけられたノートを探します",
+                    "uniqueItems": true,
+                    "minItems": 1,
+                    "maxItems": 16,
+                    "items": {
+                      "type": "string"
+                    }
+                  },
+                  "reactionsExclude": {
+                    "type": "array",
+                    "description": "指定したリアクションがつけられていないノートを探します",
+                    "uniqueItems": true,
+                    "minItems": 1,
+                    "maxItems": 16,
+                    "items": {
+                      "type": "string"
+                    }
+                  },
                   "sinceId": {
                     "type": "string",
                     "description": "指定されたID以降のノートを返します",
@@ -62809,10 +62829,7 @@
                     "default": null,
                     "description": "ノートを作成したユーザーのID"
                   }
-                },
-                "required": [
-                  "query"
-                ]
+                }
               }
             }
           }
@@ -62849,6 +62866,15 @@
                       }
                     }
                   },
+                  "UNIMPLEMENTED": {
+                    "value": {
+                      "error": {
+                        "message": "Reaction Search is unimplemented",
+                        "code": "UNIMPLEMENTED",
+                        "id": "64d1dbf5-c14c-406e-88da-0f799b4b42ea"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 17.24138% with 168 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (2801c8c) to head (07f2388).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 8.19% 112 Missing ⚠️
packages/frontend/src/pages/search.anote.vue 0.00% 42 Missing ⚠️
.../src/server/api/endpoints/notes/advanced-search.ts 63.88% 13 Missing ⚠️
packages/backend/src/core/ReactionService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #496      +/-   ##
===========================================
+ Coverage    40.33%   40.45%   +0.11%     
===========================================
  Files         1668     1675       +7     
  Lines       225103   226407    +1304     
  Branches      3857     3803      -54     
===========================================
+ Hits         90802    91591     +789     
- Misses      133654   134169     +515     
  Partials       647      647              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Oct 15, 2024
@penginn-net penginn-net changed the title Feat: リアクション検索 Enhance: リアクション検索 Oct 16, 2024
@penginn-net penginn-net merged commit 1ac8135 into yojo-art:develop Oct 16, 2024
29 of 30 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
@penginn-net penginn-net deleted the re-reaction-search branch December 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

検索キーワード無しのadvanced-search リアクション検索
2 participants