Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: 高度な検索でフォロー中/フォロー外を検索条件にできるように #503

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Resolve #186
高度な検索でフォロー中/フォロー外を検索条件にできるように

Why

#186

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 17.94872% with 32 lines in your changes missing coverage. Please review.

Project coverage is 40.43%. Comparing base (7abb4ab) to head (f3dc3e8).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/AdvancedSearchService.ts 0.00% 14 Missing ⚠️
packages/frontend/src/pages/search.anote.vue 0.00% 12 Missing ⚠️
packages/backend/src/core/QueryService.ts 16.66% 5 Missing ⚠️
.../src/server/api/endpoints/notes/advanced-search.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #503       +/-   ##
============================================
- Coverage    60.00%   40.43%   -19.58%     
============================================
  Files          882     1675      +793     
  Lines       102270   226446   +124176     
  Branches      1560     3769     +2209     
============================================
+ Hits         61371    91553    +30182     
- Misses       40878   134245    +93367     
- Partials        21      648      +627     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -62796,6 +62796,16 @@
                     "default": "combined",
                     "description": "添付ファイルのセンシティブ状態"
                   },
+                  "followingFilter": {
+                    "type": "string",
+                    "enum": [
+                      "following",
+                      "notFollowing",
+                      "combined"
+                    ],
+                    "default": "combined",
+                    "description": "ユーザーのフォロー状態"
+                  },
                   "offset": {
                     "type": "integer",
                     "default": 0,

Get diff files from Workflow Page

@penginn-net penginn-net self-assigned this Oct 17, 2024
@penginn-net penginn-net merged commit 8b0fd6f into yojo-art:develop Oct 17, 2024
29 of 30 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
@penginn-net penginn-net deleted the re-ff-search branch December 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

高度な検索FF内外検索
2 participants