Skip to content

非ログイン時に動きのあるMFMを動かすか選べるように #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 18, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Oct 18, 2024

What

非ログイン時に動きのあるMFMを動かすか選べるようにした

Why

非ログイン時でも選べたほうが便利
https://xn--vusz0j.art/notes/01JAEY70CJRZJ9EGXZYDW0XP57

Additional info (optional)

設定はクライアントに保持する

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 changed the title Play mfm 非ログイン時に動きのあるMFMを動かすか選べるように Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 56.33803% with 31 lines in your changes missing coverage. Please review.

Project coverage is 20.07%. Comparing base (a64fc9f) to head (084bccc).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 18 Missing ⚠️
packages/frontend/src/scripts/collapsed.ts 13.33% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #508       +/-   ##
============================================
- Coverage    60.09%   20.07%   -40.02%     
============================================
  Files          882      789       -93     
  Lines       102334   117735    +15401     
  Branches      2642     1091     -1551     
============================================
- Hits         61495    23638    -37857     
- Misses       40782    93506    +52724     
- Partials        57      591      +534     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 self-assigned this Oct 18, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Oct 18, 2024
@kozakura913 kozakura913 merged commit b2eb0bf into yojo-art:develop Oct 18, 2024
16 of 17 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants