Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: i/notifications-groupedで新規投稿はgroupNewNotes: trueでなければまとめないように #632

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

penginn-net
Copy link
Collaborator

What

i/notifications-groupedで新規投稿はgroupNewNotes: trueでなければまとめないように

Why

一部クライアントが壊れるらしいので

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Jan 29, 2025

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -47402,6 +47402,10 @@
                         "pollVote"
                       ]
                     }
+                  },
+                  "groupNewNotes": {
+                    "type": "boolean",
+                    "default": false
                   }
                 }
               }

Get diff files from Workflow Page

@kozakura913 kozakura913 added this to the 1.4.0 milestone Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.00%. Comparing base (1a86945) to head (81ffc7e).

Files with missing lines Patch % Lines
...rc/server/api/endpoints/i/notifications-grouped.ts 50.00% 1 Missing ⚠️
...ckages/frontend/src/components/MkNotifications.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #632      +/-   ##
===========================================
- Coverage    40.02%   40.00%   -0.02%     
===========================================
  Files         1698     1698              
  Lines       236659   236661       +2     
  Branches      3952     3938      -14     
===========================================
- Hits         94717    94682      -35     
- Misses      141275   141312      +37     
  Partials       667      667              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913
Copy link
Collaborator

リリースしたからCHANGELOG_YOJO.mdの修正が必要

@kozakura913
Copy link
Collaborator

#625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants