Fix Linux support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a preview video recorded on Linux: CN (P2): https://www.bilibili.com/video/BV19o4y1y7ki/ |
|
I didn't has a Mac or Linux machine so I can't test those thing. The implementation of MacOS support was provided by another contributor (see #2). I thought that also provide support for Linux but It may be wrong since I didn't really tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux support in the latest release is broken. This repo contains a old version of SFB without Linux support. Running the Linux build of the latest release v0.3.10 and clicking the song cover results in this error:
It's because the bundled version of SFB doesn't have Linux support.
The latest version 1.2 of SFB has Linux support but it's broken (gkngkc/UnityStandaloneFileBrowser#43). I fixed it in my fork.
Note that I have NOT tested it because I failed to to build Arcade-plus. So it shouldn't be merged right now. But I have tested it in Arcade Zero (another fork of Arcade). I'll test it ASAP after I manage to build this project.I have tested it on my Linux PC and it works.