feature #88 - Add helper method to log error without adding failure #114
Conversation
There was a problem hiding this comment.
Hi @guich25!
Thanks for your help, please have a look to the GH actions that seems to be failing
| use Yokai\Batch\JobExecution; | ||
| use Yokai\Batch\Storage\JobExecutionStorageInterface; | ||
|
|
||
| class JobWithFailureErrorLogTest extends JobTestCase |
There was a problem hiding this comment.
I don't think an integration test is expected for that kind of feature
Maybe you should just add your test case here: https://github.com/yokai-php/batch-src/blob/0.x/src/batch/tests/JobExecutionTest.php
guich25
force-pushed
the
88_feature_add_to_log_whitout_failure
branch
4 times, most recently
from
9d4ac48 to
cb95719
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.x #114 +/- ##
=========================================
Coverage 99.67% 99.67%
- Complexity 840 844 +4
=========================================
Files 138 139 +1
Lines 2485 2494 +9
=========================================
+ Hits 2477 2486 +9
Misses 8 8 ☔ View full report in Codecov by Sentry. |
guich25
force-pushed
the
88_feature_add_to_log_whitout_failure
branch
from
cb95719 to
dfe2283
Compare
yann-eugone
changed the title
| use Yokai\Batch\Factory\UniqidJobExecutionIdGenerator; | ||
| use Yokai\Batch\JobExecution; | ||
|
|
||
| class LoggerTest extends TestCase |
There was a problem hiding this comment.
The test class is not in the right dir, this is why Codecov is not seeing the coverage
tests/convention/Job/LoggerTest.php instead of src/batch/tests/Job/LoggerTest.php
guich25
changed the title
See issue #88