Skip to content

Conversation

guich25
Copy link
Contributor

@guich25 guich25 commented Jan 11, 2024

see #98 for feature request

@guich25 guich25 force-pushed the 98_allow_to_count_jobexecution_query branch 13 times, most recently from d7e3ec9 to ebf7b40 Compare January 11, 2024 22:27
@guich25 guich25 force-pushed the 98_allow_to_count_jobexecution_query branch from 192be45 to a4f7ecb Compare February 28, 2024 08:17
@yann-eugone yann-eugone force-pushed the 98_allow_to_count_jobexecution_query branch from a4f7ecb to ac3efd1 Compare January 8, 2025 10:43
@yann-eugone yann-eugone force-pushed the 98_allow_to_count_jobexecution_query branch from 6893fc0 to 9bf7a15 Compare January 8, 2025 11:11
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (cf1c154) to head (9bf7a15).
Report is 1 commits behind head on 0.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                0.x     #117   +/-   ##
=========================================
  Coverage     99.72%   99.72%           
- Complexity      906      909    +3     
=========================================
  Files           147      147           
  Lines          2879     2892   +13     
=========================================
+ Hits           2871     2884   +13     
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yann-eugone yann-eugone changed the title feature #98 Total count JobExecution matched by query Allow fetching total count JobExecution matched by query Jan 8, 2025
@yann-eugone yann-eugone self-requested a review January 8, 2025 11:13
@yann-eugone yann-eugone marked this pull request as ready for review January 8, 2025 11:13
Copy link
Contributor

@yann-eugone yann-eugone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased the code and it now seems to work
Thank you @guich25

@yann-eugone yann-eugone merged commit e015262 into 0.x Jan 8, 2025
11 checks passed
@yann-eugone yann-eugone deleted the 98_allow_to_count_jobexecution_query branch January 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants