Skip to content

Conversation

yann-eugone
Copy link
Contributor

After adding some tests on #123
I realised that it is not possible to check on services definitions inside the bundle extension
Because at this point, the ContainerBuilder received is almost empty

I had to introduce some compiler passes to do that checks

I've changed the extension tests to have more specific tests rather than single test method with too much configuration

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (cf1c154) to head (6ef9ccf).
Report is 4 commits behind head on 0.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                0.x     #134   +/-   ##
=========================================
  Coverage     99.72%   99.72%           
- Complexity      906      910    +4     
=========================================
  Files           147      150    +3     
  Lines          2879     2912   +33     
=========================================
+ Hits           2871     2904   +33     
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yann-eugone yann-eugone requested a review from J-Ben87 January 8, 2025 10:21
@yann-eugone yann-eugone merged commit b9fe153 into 0.x Jan 9, 2025
11 checks passed
@yann-eugone yann-eugone deleted the fix-custom-services-in-extension branch January 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants