Get rid of unecessary phpstan prefix in some annotations #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.x #135 +/- ##
=========================================
Coverage 99.72% 99.72%
Complexity 909 909
=========================================
Files 147 147
Lines 2892 2892
=========================================
Hits 2884 2884
Misses 8 8 ☔ View full report in Codecov by Sentry. |
|
This needs to be merged and has no runtime effect, review can be added afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point of history, IDEs were late on some advanced typing notations
We used to write some instruction for phpstan only
Now IDE understand phpstan almost perfectly
We can remove the phpstan prefix from most annotations