Add Rick and Morty import Job in Symfony test suite #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-eugone
commented
Jan 29, 2025
| use Yokai\Batch\Job\Parameters\StaticValueParameterAccessor; | ||
| use Yokai\Batch\Storage\JobExecutionStorageInterface; | ||
|
|
||
| final class ImportStarWarsJobFactory |
There was a problem hiding this comment.
Replaced the abstract class with this Factory service
Less dependencies mess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data were taken from https://rickandmortyapi.com/
JSON files are API pages used for MockHttpClient
I also made some changes to other jobs in that suite so it shows latests recommendation for structuring jobs