Skip to content

Avoid final classes for jobs but add final to methods #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Avoid final classes for jobs but add final to methods #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/batch/src/Job/AbstractJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ abstract class AbstractJob implements JobInterface
/**
* @inheritDoc
*/
public function execute(JobExecution $jobExecution): void
final public function execute(JobExecution $jobExecution): void
{
if (!$jobExecution->getStatus()->isExecutable()) {
$jobExecution->getLogger()->error('Job is not executable', ['job' => $jobExecution->getJobName()]);
Expand Down
2 changes: 1 addition & 1 deletion src/batch/src/Job/Item/ItemJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function __construct(
/**
* @inheritDoc
*/
protected function doExecute(JobExecution $jobExecution): void
final protected function doExecute(JobExecution $jobExecution): void
{
$rootExecution = $jobExecution->getRootExecution();
$summary = $jobExecution->getSummary();
Expand Down
4 changes: 2 additions & 2 deletions src/batch/src/Job/JobWithChildJobs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Yokai\Batch\Registry\JobRegistry;
use Yokai\Batch\Storage\JobExecutionStorageInterface;

final class JobWithChildJobs extends AbstractJob
class JobWithChildJobs extends AbstractJob
{
/**
* @var JobExecutionStorageInterface
Expand Down Expand Up @@ -44,7 +44,7 @@ public function __construct(
/**
* @inheritDoc
*/
protected function doExecute(JobExecution $jobExecution): void
final protected function doExecute(JobExecution $jobExecution): void
{
$logger = $jobExecution->getLogger();
foreach ($this->childJobs as $jobName) {
Expand Down