Let item reader to drive item indexes #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.x #32 +/- ##
============================================
+ Coverage 92.84% 92.90% +0.05%
- Complexity 620 628 +8
============================================
Files 100 101 +1
Lines 1789 1804 +15
============================================
+ Hits 1661 1676 +15
Misses 128 128
Continue to review full report at Codecov.
|
yann-eugone
force-pushed
the
read-index
branch
from
a55a9e3 to
eb20cee
Compare
halundraN
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, library was using an "auto incremented" index to identify an item in the batch.
With this change, reader is allowed to determine what should be the item id.
If nothing is done, we will end to an auto-incremented integer, starting to 0.
This PR also introduce a reader decorator able to extract id from data read.