Skip to content

Conversation

yann-eugone
Copy link
Contributor

No description provided.

@yann-eugone yann-eugone force-pushed the box-spout-bridge-refactoring branch from 98b8365 to dd81fb1 Compare February 27, 2022 09:19
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #50 (ec6cf7c) into 0.x (d27a214) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                 0.x       #50    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity       665       710    +45     
============================================
  Files            110       120    +10     
  Lines           1842      1956   +114     
============================================
+ Hits            1842      1956   +114     
Impacted Files Coverage Δ
...ox-spout/src/Exception/InvalidRowSizeException.php 100.00% <100.00%> (ø)
src/batch-box-spout/src/Reader/FlatFileReader.php 100.00% <100.00%> (ø)
src/batch-box-spout/src/Reader/HeaderStrategy.php 100.00% <100.00%> (ø)
.../batch-box-spout/src/Reader/Options/CSVOptions.php 100.00% <100.00%> (ø)
.../batch-box-spout/src/Reader/Options/ODSOptions.php 100.00% <100.00%> (ø)
...batch-box-spout/src/Reader/Options/SheetFilter.php 100.00% <100.00%> (ø)
...batch-box-spout/src/Reader/Options/XLSXOptions.php 100.00% <100.00%> (ø)
src/batch-box-spout/src/Writer/FlatFileWriter.php 100.00% <100.00%> (ø)
.../batch-box-spout/src/Writer/Options/CSVOptions.php 100.00% <100.00%> (ø)
.../batch-box-spout/src/Writer/Options/ODSOptions.php 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27a214...ec6cf7c. Read the comment docs.

@yann-eugone yann-eugone force-pushed the box-spout-bridge-refactoring branch from dd81fb1 to fa27e26 Compare February 28, 2022 08:09
Copy link
Contributor

@J-Ben87 J-Ben87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très bien le nouveau système d'options, je valide !

@yann-eugone yann-eugone merged commit 654adc4 into 0.x Feb 28, 2022
@yann-eugone yann-eugone deleted the box-spout-bridge-refactoring branch February 28, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants