Skip to content

Conversation

yann-eugone
Copy link
Contributor

@yann-eugone yann-eugone commented May 14, 2022

yokai/batch is working on files for both reading or writing, but it is often required to download the file to be read, or upload the file that was written.
There is currently no "official" way to do such things.

https://github.com/thephpleague/flysystem is the most famous "filesystem abstraction library", it has a wide support of most filesystem types.

What could be done

  • A job to copy files, could be used to both download or upload, using filesystem abstraction
  • A job to move files, could be used to both download or upload, using filesystem abstraction
  • A scheduler to trigger a job whenever a file exists on filesystem

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #61 (bf37543) into 0.x (69b3cf6) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                 0.x       #61   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       724       752   +28     
===========================================
  Files            124       127    +3     
  Lines           1846      1939   +93     
===========================================
+ Hits            1846      1939   +93     
Impacted Files Coverage Δ
src/batch/src/Trigger/Scheduler/ScheduledJob.php 100.00% <ø> (ø)
...rc/batch-league-flysystem/src/Job/CopyFilesJob.php 100.00% <100.00%> (ø)
...rc/batch-league-flysystem/src/Job/MoveFilesJob.php 100.00% <100.00%> (ø)
...gue-flysystem/src/Scheduler/FileFoundScheduler.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b3cf6...bf37543. Read the comment docs.

@yann-eugone yann-eugone force-pushed the league-flysystem-bridge branch from 78df010 to fb06bc9 Compare May 14, 2022 11:09
@yann-eugone yann-eugone requested review from halundraN and J-Ben87 May 18, 2022 06:44
@yann-eugone yann-eugone merged commit 9976efb into 0.x May 31, 2022
@yann-eugone yann-eugone deleted the league-flysystem-bridge branch June 18, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants