Skip to content

Avoid to show the transition if the current admin is not the one which transition applies to #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2019
Merged

Avoid to show the transition if the current admin is not the one which transition applies to #12

merged 1 commit into from
Sep 26, 2019

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Sep 7, 2019

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@yann-eugone
Copy link
Contributor

Didn't had chance to test this library with child admins, but confident with the code you wrote.
Thanks

@yann-eugone yann-eugone merged commit b610c43 into yokai-php:master Sep 26, 2019
@phansys phansys deleted the child_admin branch September 26, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@n4huel n4huel n4huel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phansys @yann-eugone @n4huel