Skip to content

Tests on PHP 7.4 & Symfony 5.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2020
Merged

Tests on PHP 7.4 & Symfony 5.0 #17

merged 3 commits into from
Feb 28, 2020

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Jan 9, 2020 •
edited
Loading

  • Build on PHP 7.4;
  • Implement own StubTranslator;
  • Allow "symfony/workflow:5.0".

Closes #16.

@phansys phansys force-pushed the tests branch 8 times, most recently from c4bc61a to 9534250 Compare January 10, 2020 00:46
@phansys phansys marked this pull request as ready for review January 10, 2020 00:46
@yann-eugone yann-eugone changed the title Update tests Tests on PHP 7.4 & Symfony 5.0 Jan 11, 2020
yann-eugone
yann-eugone requested changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@yann-eugone yann-eugone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this one. I didn't do it before because I was not sure that sonata is supporting symfony 5.x yet, but at least, we will be ready.

yann-eugone
yann-eugone approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@yann-eugone yann-eugone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition. Sorry it take that long to be approved.

@yann-eugone yann-eugone merged commit 3705681 into yokai-php:master Feb 28, 2020
@phansys
Copy link
Contributor Author

phansys commented Feb 28, 2020

No problem at all. This is how we can deliver our time for OSS 👍

@phansys phansys deleted the tests branch February 28, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yann-eugone yann-eugone yann-eugone approved these changes

+1 more reviewer

@n4huel n4huel n4huel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phansys @yann-eugone @n4huel