Skip to content

Conversation

yann-eugone
Copy link
Contributor

@yann-eugone yann-eugone commented Jun 2, 2021

There is too much differences between Sonata 3.x & 4.x.

Decided to drop sonata 4.x support for the next version :

  • PHP >= 7.4
  • Symfony >= 4.4
  • Sonata >= 4.0

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #30 (fd7fda3) into main (5f0f6bd) will increase coverage by 0.11%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #30      +/-   ##
============================================
+ Coverage     91.02%   91.13%   +0.11%     
  Complexity       44       44              
============================================
  Files             2        2              
  Lines           156      158       +2     
============================================
+ Hits            142      144       +2     
  Misses           14       14              
Impacted Files Coverage Δ
src/Controller/WorkflowControllerTrait.php 81.42% <80.00%> (ø)
src/Admin/Extension/WorkflowExtension.php 98.86% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0f6bd...fd7fda3. Read the comment docs.

@danaki
Copy link

danaki commented Jun 6, 2021

RouterCollection should be replaced by RouterCollectionInterface, but now I'm getting strange error like:

An exception has been thrown during the rendering of a template ("unable to find the route `admin_app_productfeedback.workflow_apply_transition`").

While I have this route configure except it has "_" instead of ".":

  admin_app_productfeedback_workflow_apply_transition         ANY      ANY      ANY    /admin/app/productfeedback/{id}/workflow/transition/{transition}/apply

@yann-eugone
Copy link
Contributor Author

RouterCollection should be replaced by RouterCollectionInterface, but now I'm getting strange error like:

Yes, but I see no way to have single version of this library for the 2 versions of SonataAdmin. And as there is no date for the 4.x stable version, I'm not sure I want to create a new major for the moment.


The other error is very strange indeed, because the library never calls the router with entire route names.
All routes are generated using AdminInterface::generateObjectUrl(), I'm really not sure why you are getting something like this.

@danaki danaki mentioned this pull request Jun 10, 2021
@danaki
Copy link

danaki commented Jun 10, 2021

After composer update problems with routes have gone away.

@yann-eugone yann-eugone requested a review from a team October 18, 2021 08:25
@yann-eugone yann-eugone merged commit ea912e9 into main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants