-
Notifications
You must be signed in to change notification settings - Fork 14
Compatibility with Sonata 4.x #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
============================================
+ Coverage 91.02% 91.13% +0.11%
Complexity 44 44
============================================
Files 2 2
Lines 156 158 +2
============================================
+ Hits 142 144 +2
Misses 14 14
Continue to review full report at Codecov.
|
RouterCollection should be replaced by RouterCollectionInterface, but now I'm getting strange error like:
While I have this route configure except it has "_" instead of ".":
|
Yes, but I see no way to have single version of this library for the 2 versions of SonataAdmin. And as there is no date for the 4.x stable version, I'm not sure I want to create a new major for the moment. The other error is very strange indeed, because the library never calls the router with entire route names. |
After composer update problems with routes have gone away. |
There is too much differences between Sonata 3.x & 4.x.
Decided to drop sonata 4.x support for the next version :