Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-depends] bump m4 to 1.4.17 #48

Merged
merged 1 commit into from
Aug 7, 2017
Merged

[pre-depends] bump m4 to 1.4.17 #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/depends/pre-depends/m4-pre-depends/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
include ../../Makefile.include.in
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught my eye, but: What good does including the .in file here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define at least BASE_URL

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../../Makefile.include doesn't exist at the time this file is used

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Ensures lots of env variables with werid values but it doesn't seem to be a problem.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../../Makefile.include doesn't exist at the time this file is used

Yes, best would be to separate the configured and the unconfigured (static) stuff into two files. Just nitpicking though ;-)

DEPS=Makefile
PREFIX=$(CURDIR)/../../pre-build-deps
PLATFORM=native
TARBALLS_LOCATION=$(PREFIX)
RETRIEVE_TOOL=curl
ARCHIVE_TOOL=tar
# lib name, version
LIBNAME=m4
VERSION=1.4.9
VERSION=1.4.17
SOURCE=$(LIBNAME)-$(VERSION)
ARCHIVE=$(SOURCE).tar.gz

# configuration settings
CONFIGURE=./configure --prefix=$(PREFIX)

LIBDYLIB=$(PLATFORM)/bin/$(LIBNAME)
LIBDYLIB=$(PLATFORM)/src/$(LIBNAME)

CLEAN_FILES=$(ARCHIVE) $(PLATFORM)

Expand Down