Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Anki card flags #1571

Merged
merged 20 commits into from
Nov 6, 2024
Merged

Show Anki card flags #1571

merged 20 commits into from
Nov 6, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Nov 5, 2024

Fixes #333

Blocking on AnkiConnect lacking support for flags. I've contacted foosoft to get support for this merged in. Currently using this patch to test: 0001-Add-support-for-flags.txt.

Older AnkiConnect versions without flag support will still work fine, there are no errors, it just wont be able to show any flags.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design area/anki The issue or PR is related to Anki integration labels Nov 5, 2024
@Kuuuube
Copy link
Member Author

Kuuuube commented Nov 5, 2024

This is all good to go now, just blocking on AnkiConnect support.

Single flag/multiple flags of the same color:
image

Multiple flags of different colors:
image

Copy link

github-actions bot commented Nov 5, 2024

Playwright test results

failed  1 failed
passed  4 passed

Details

stats  5 tests across 4 suites
duration  4 minutes, 40 seconds
commit  c95b938

Failed tests

chromium › visual.spec.js › visual

@Kuuuube Kuuuube marked this pull request as ready for review November 6, 2024 02:32
@Kuuuube Kuuuube requested a review from a team as a code owner November 6, 2024 02:32
@Kuuuube
Copy link
Member Author

Kuuuube commented Nov 6, 2024

Support for flags has been merged into AnkiConnect. This PR is no longer blocked.

jamesmaa
jamesmaa previously approved these changes Nov 6, 2024
ext/js/display/display-anki.js Outdated Show resolved Hide resolved
ext/settings.html Show resolved Hide resolved
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #1571 will not alter performance

Comparing Kuuuube:show-flags (e6b3e5f) with master (c95b938)

Summary

✅ 3 untouched benchmarks

jamesmaa
jamesmaa previously approved these changes Nov 6, 2024
ext/js/comm/anki-connect.js Show resolved Hide resolved
@Kuuuube Kuuuube added this pull request to the merge queue Nov 6, 2024
Merged via the queue into yomidevs:master with commit adaf066 Nov 6, 2024
12 checks passed
@Kuuuube Kuuuube deleted the show-flags branch November 6, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flags and editing QoL
2 participants