Break cycle between Dir and Entry (dune 3.7) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(see discussion in ocaml/dune#7018) |
There is a dependency cycle in `lib`: `entry.ml` depends on `Dir`, and `dir.mli` depends on `Entry`. Dune used to be OK with that, but the new dependency analysis algorithm in 3.7 makes tighter checks and (correctly) detects it. It's kinda OK in that particular case because `Dir` only uses a type alias from `Entry`, but dune can not reliably detect this. So this PR adds an extra `Entry0` module with just the type definition, in a way that splits the cycle and makes it compatible with dune 3.7.
emillon
force-pushed
the
split-dependency-cycle
branch
from
b4ffdd1 to
8e9c0b5
Compare
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Feb 20, 2023
Two packages got broken by dune 3.7: commons and chamelon. They were relying on behavior in dune's dependency cycle detection that we classified as a bug (see ocaml/dune#7018). Since the latest versions are affected, we sent patches upstream: yomimono/chamelon#18, semgrep/semgrep#7173.
This was referenced Feb 23, 2023
|
Thanks, @emillon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While preparing dune 3.7 we noticed that this library used to build, but does not anymore.
After investigating, there is a dependency cycle in
lib:entry.mldepends onDir, anddir.mlidepends onEntry.Dune used to be OK with that, but the new dependency analysis algorithm in 3.7 makes tighter checks and (correctly) detects it. It's kinda OK in that particular case because
Dironly uses a type alias forEntry, but dune can not reliably detect this. So arguablychamelonused to rely on a bug in dune.So this PR adds an extra
Entry0module with just the type definition, in a way that splits the cycle and makes it compatible with dune 3.7.A alternative would be to expand the type alias in
dir.mli.