7.0 Update #3
Open
7.0 Update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NamePlateGui was added to Dalamud and is out on stable, this should be good to go |
…ry nowdays. Fix empty title check. A bit of cleanup as a result of SeStringWrapper removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
SetNamePlateDelegatewas inlined it's now required to use an alternative method for nameplate updates. Right now I tested it against #1915 but changes might need to be made in the future.The only relevant note is that it seems the way
SeStringwas setup doesn't quite work properly anymore, as such I'm only using Dalamud's implementation. I don't really see a need for the previous implementation either, since right now you can just work with strings, removing the need to handle pointers and memory allocation for them.Ultimately I didn't touch anything that worked, since I figured you'd want to do it yourself, or in a specific manner.