Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm-bridge): add x.ai provider #927

Merged
merged 5 commits into from
Oct 25, 2024
Merged

feat(llm-bridge): add x.ai provider #927

merged 5 commits into from
Oct 25, 2024

Conversation

fanweixiao
Copy link
Member

@fanweixiao fanweixiao commented Oct 23, 2024

add x.ai support

Caution

Function calling is currently not working due to an API bug.

/chat/completions endpoint works, but the function calling feature is still affected by the x.ai API error.

Official Docs state that the finish_reason should be tool_calls, but API returns stop, this breaks the system.

image

We will fix it as soon as x.ai resolves the API bug.

@fanweixiao fanweixiao added the feat Features which undefined clearly label Oct 23, 2024
@fanweixiao fanweixiao self-assigned this Oct 23, 2024
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 3:31am

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.31%. Comparing base (bb8e3db) to head (fc48515).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   79.07%   78.31%   -0.76%     
==========================================
  Files          50       51       +1     
  Lines        2958     3713     +755     
==========================================
+ Hits         2339     2908     +569     
- Misses        449      634     +185     
- Partials      170      171       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woorui woorui merged commit 4dcfc56 into master Oct 25, 2024
6 of 7 checks passed
@woorui woorui deleted the feat/x-ai branch October 25, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Features which undefined clearly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants