feat(cli): remove deno serverless & support run .ts serverless in nodejs #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
=========================================
Coverage ? 78.84%
=========================================
Files ? 51
Lines ? 3725
Branches ? 0
=========================================
Hits ? 2937
Misses ? 617
Partials ? 171 ☔ View full report in Codecov by Sentry. |
fanweixiao
approved these changes
Oct 31, 2024
| if err != nil { | ||
| return nil, errors.New("[node] command was not found. to run the sfn in ts, you need to install node. For details, visit https://nodejs.org") | ||
| } | ||
| npmPath, err := exec.LookPath("pnpm") |
|
|
||
| ext := filepath.Ext(entryTSFile) | ||
| if ext != ".ts" { | ||
| return nil, fmt.Errorf("only support typescript, got: %s", entryTSFile) |
There was a problem hiding this comment.
support Typescript only in current version
| } | ||
|
|
||
| // 2. install dependencies | ||
| cmd := exec.Command(w.npmPath, "install") |
There was a problem hiding this comment.
@houjiazong when hosting, usually need npm install --production
| return err | ||
| } | ||
|
|
||
| listener, err := net.ListenUnix("unix", addr) |
woorui
changed the title
|
example-8 needs to be removed |
wujunzhuo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TypeScriptto write a llm sfn, For an example, refer toexample/10-ai/llm-sfn-get-weather-ts.yomo run app.tscommand to run the ts sfn.