Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(llm-bridge): improve log and trace #938

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Nov 9, 2024

  1. Enhance llm bridge logging, add service, namespace, traceId, requestId, duration field.
  2. The Bridge's http handler supports the injection of tracer.
  3. Yomo exports the global trace client.
  4. Add new ResponseWriter struct, the ResponseWriter supports record errors and TTFT timing.

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 9:21am

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 78.21229% with 39 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (2221a74) to head (bd44464).

Files with missing lines Patch % Lines
pkg/bridge/ai/api_server.go 69.01% 18 Missing and 4 partials ⚠️
pkg/bridge/ai/response_writer.go 79.54% 6 Missing and 3 partials ⚠️
pkg/bridge/ai/service.go 87.75% 5 Missing and 1 partial ⚠️
pkg/bridge/ai/ai.go 0.00% 1 Missing ⚠️
pkg/trace/trace.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   78.01%   77.87%   -0.14%     
==========================================
  Files          51       52       +1     
  Lines        3725     3810      +85     
==========================================
+ Hits         2906     2967      +61     
- Misses        649      668      +19     
- Partials      170      175       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@woorui woorui marked this pull request as ready for review November 14, 2024 07:47
@woorui woorui self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants