set position bugged after 1.37.5

[VegarRingdalAibel]

Describe the bug

Hi

Tried to create sample showing setPosition is broken after 1.37.5

To Reproduce

See animated gifs

Live example

https://codesandbox.io/s/musing-mccarthy-zqneho?file=/src/index.js

You can switch between version here

Expected behavior

To use correct position and target, not using the offset its doing now after 1.37.5

Screenshots or Video

Bugged behavior

Bugged: I save 4 target/positions, but when I move camera, it stays in same position and not the one I saved

Expected behavior

Device

Desktop

OS

Windows

Browser

Chrome

[yomotsu]

Thanks for the code. It was helpful.

Actually both setTarget() and setPosition() are alias of setLookAt() and you are calling the same function at the same time eventually.
see:

camera-controls/src/CameraControls.ts

Lines 1909 to 1950 in 2014f46

	/**
	* setLookAt without target, keep gazing at the current target
	* @param positionX
	* @param positionY
	* @param positionZ
	* @param enableTransition
	* @category Methods
	*/
	setPosition( positionX: number, positionY: number, positionZ: number, enableTransition: boolean = false ): Promise<void> {
	return this.setLookAt(
	positionX, positionY, positionZ,
	this._targetEnd.x, this._targetEnd.y, this._targetEnd.z,
	enableTransition,
	);
	}
	/**
	* setLookAt without position, Stay still at the position.
	* @param targetX
	* @param targetY
	* @param targetZ
	* @param enableTransition
	* @category Methods
	*/
	setTarget( targetX: number, targetY: number, targetZ: number, enableTransition: boolean = false ): Promise<void> {
	const pos = this.getPosition( _v3A );
	const promise = this.setLookAt(
	pos.x, pos.y, pos.z,
	targetX, targetY, targetZ,
	enableTransition,
	);
	// see https://github.com/yomotsu/camera-controls/issues/335
	this._sphericalEnd.phi = clamp( this.polarAngle, this.minPolarAngle, this.maxPolarAngle );
	return promise;
	}

Thus, you are overwriting the first one with the second one. Therefore, setPosition() is not working in your code.
How about using setLookAt() instead?

[VegarRingdalAibel]

setPosition worked perfectly combined with setTarget in 1.37.5 so I though it was a bug. 😄
Ill give the setLookAt a try, from the code sample above it looks to solve my issue

[yomotsu]

I though it was a bug

TBH...I thought so...
But according to the code, the current version is more expected behavior.

[VegarRingdalAibel]

thx