Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply polar angle constraints in the setTarget method #336

Merged

Conversation

virgilbugnariu
Copy link
Contributor

Fixes #335

@yomotsu
Copy link
Owner

yomotsu commented Jan 19, 2023

@virgilbugnariu

Thanks for your first contribution!
It seems your commit removing necessary spaces in comments.
(2 spaces are for line breaks in markdown syntax)

Would you mind checking the diff, please?

@virgilbugnariu
Copy link
Contributor Author

Yes, looks like my IDE did that automatically, I was not sure if that would be a problem. I will revert the changes on these lines and I'll update the PR. Thanks :)

@yomotsu yomotsu merged commit 259a360 into yomotsu:dev Jan 19, 2023
@yomotsu
Copy link
Owner

yomotsu commented Jan 19, 2023

Just merged!
Many thanks!

@VegarRingdalAibel
Copy link

think this broke using setPosition and setTarget
if I stay before this release it all just works

I do something like this in my code on stored "viewpoints"

Maybe Im using it wrong..

const controllerPromise1 = getCanvasController()
      .getActiveControls()
      .setPosition(
          vp.controllerPosition[0],
          vp.controllerPosition[1],
          vp.controllerPosition[2],
          true
      );

  const controllerPromise2 = getCanvasController()
      .getActiveControls()
      .setTarget(
          vp.controllerTarget[0],
          vp.controllerTarget[1],
          vp.controllerTarget[2],
          true
      );
            ```

@yomotsu
Copy link
Owner

yomotsu commented Jan 26, 2023

@VegarRingdalAibel

Would you mind opening a new issue with a working example, please?
This has been closed.

@VegarRingdalAibel
Copy link

Sure, Ill try and create something.
Just wanted to ask here incase I was using it wrong.

@VegarRingdalAibel
Copy link

Created it here: #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setTarget does not take minPolarAngle and maxPolarAngle into account
3 participants