Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support --version option #112

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Conversation

mironal
Copy link
Contributor

@mironal mironal commented Oct 27, 2017

I think that it is better for xcodegen to have --version option as it is for many commands.

However, I think that this will increase the effort of editing main.swift for version up process. 😟
If you feel troublesome, you can reject this pull request. 😇

@keith
Copy link
Collaborator

keith commented Oct 27, 2017

This would be fantastic! @yonaskolb thoughts on the extra work for shipping?

@keith keith changed the title add support --vesion option add support --version option Oct 27, 2017
@yonaskolb
Copy link
Owner

Yes, adding this is definitely a good idea. Thanks @mironal!
In terms of keeping this updated I think the version should live in one place and then a release script would update it places like this, tag a version, and also use it to update the brew formula.
The release script can live in the make file and the version could either be in there or in it's own file. Is there a standard way of doing that?

@yonaskolb
Copy link
Owner

Would this --version flag or a xcodegen version command be preferred?

@keith
Copy link
Collaborator

keith commented Oct 27, 2017

I think we should just bake that in to a build script somewhere, to sed out a variable in a swift file with a version number. Personally I prefer --version but don't feel strongly

@yonaskolb yonaskolb merged commit 53e7b2d into yonaskolb:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants