Support CompilerFlags in Sources #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkase
force-pushed
the
support-compiler-flags
branch
from
029c2c0 to
ef720ee
Compare
|
Instead of creating |
bkase
force-pushed
the
support-compiler-flags
branch
from
ef720ee to
8c1e046
Compare
|
Tests will fail for now, but will pass when #108 lands (after a rebase) |
bkase
force-pushed
the
support-compiler-flags
branch
from
8c1e046 to
ae8ff93
Compare
Added support for compilerFlags in source list. If any source file metadata (like compilerFlags) is attached to a directory the metadata propagates downwards to all children recursively until the files are reached. Files are now processed in the same way as directories in `getSources` this depends on yonaskolb#108 to not over-eagerly cache groups. The `source` is propagated as metadata down all the way (thanks @yonaskolb) Fixtures and unit tests are updated as well.
bkase
force-pushed
the
support-compiler-flags
branch
from
ae8ff93 to
6b17b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for compilerFlags in source list. If any source file
metadata (like compilerFlags) is attached to a directory the metadata
propagates downwards to all children recursively until the files are
reached.
Since there is an extra bit of metadata we need to carry around during
production of PBXObjects, we can no longer pass a
Pathdirectly.Sourceneedspathto beStringbecause we don't know thebasePath until the spec is fully loaded. When we do have the basePath
we can compute the real
Pathand start to use PathKit APIs.I attempted a first pass where I just used the
Sourceeverywhere andforwarded along a basePath at all operations that needed it, but that
was too messy, so I ended up making another struct that enriched the
source with the basePath (called
EnrichedSource). I don't love thename, let me know if you come up with a better one.
Fixtures and unit tests are updated as well.