Make references more deterministic #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
force-pushed
the
deterministic_references
branch
2 times, most recently
from
1976c4f to
6ef47a1
Compare
- more characters - underscore after type name - remove duplication count unless greater than 1
yonaskolb
force-pushed
the
deterministic_references
branch
from
6ef47a1 to
034eb4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more identifying behaviour for a few reference generations, to make the references more unique and more deterministic.
In the test fixture, this removes all the cases of references that had to have a duplication count appended to make them unique (references with a suffix of 02 rather than 01)